"Reload font" with all selected should reload all fonts

[kontur]

Hey,

initially I was under the impression that when several fonts are in the window and I select them all, then right-click and chose "Reload font" it would reload all fonts. I later noticed this just reloads the font above which the user right-clicked, which I think is counter intuitive.

Either there should be a "Reload all fonts" or "Reload selected" or it should reload all selected if there are selected fonts.

Very minor but confused me when I was trying to debug why some fonts would get updated features and others not :)

[justvanrossum]

The contextual menu indeed does not work with the selection, and I see how that can be confusing. I'll try to think how this could be improved.

In general, reload happens automatically, though. In what kind of cases are you manually reloading fonts? It may point to an oversight or bug in FontGoggles.

[kontur]

I was recompiling fonts in place (which automatically updates) but then deleted the fonts. Just to "be sure" I'm looking at the right fonts I reloaded, e.g. to confirm the file no longer is found. Imo it's perfectly okay for the app to not react to a file being deleted without UI input, bit of a edge case. Anyway, the menu expectation holds true, it's unintuitive that it wouldn't reload all selected. The way I noticed was that only the one below the cursor showed as "file not found" whereas the others stayed in place with their rendered text.

[justvanrossum]

Thanks!

I think the behavior should be this:

• if contextual click on selected item, apply menu to all selected items
• else: select item (taking command and shift modifiers into account), then apply menu to all selected items