Justus Schock

Results 90 comments of Justus Schock

So far we don't officially support MPS for metrics. Most of the stuff should work, however. For the failing ops, we can only wait for official support from the pytorch...

@ddrevicky I think you can give it a shot, thanks! cc @teddykoker

@otaj Almost. Additionally, all metrics from `torchmetrics` would have to be considered as well as they are also capable of issuing syncs on their own. And in general, the user...

if we can capture user calls with that, it might work similarly with `torchmetrics`. So let's ignore those metrics for now and if you got a working solution for everything...

question is: Will we consider this as a breaking change or do we expect that nobody except us uses that? grep.app only shows usage of that from other frameworks/other languages...

But that way we would always at least once trigger the warning because we internally import the MisconfigurationException, no?

Should we discuss here how we would we will handle error inheritance here? Especially w.r.t deprecating it and avoiding raised errors when importing it within our code? I think we...

Also note that we might want to also add a custom implementation of `__repr__` definition as we want to show them as plain python errors. E.g. we want something like...

I think the best would be to open a draft PR so that we can directly review the code at hand :) Of course if you have any questions before...

@SkafteNicki I would not used 2. as it is easy to break something we are not aware of that way. I suggest introducing https://github.com/Lightning-AI/utilities as a dependency and rely on...