django-activity-stream icon indicating copy to clipboard operation
django-activity-stream copied to clipboard

Reloading django apps is problematic

Open v1kku opened this issue 4 years ago • 3 comments

In apps.py django_jsonfield_backport is added to INSTALLED_APPS and django is forced to reload the apps. This is problematic for projects that perform non-idempotent operations in their apps' ready method. 3rd party packages should not be doing this. Can't that check just report an error asking the user to add django_jsonfield_backport to INSTALLED_APPS (and a warning that reminds them to remove it if django>=3.1)? I'm happy to make a PR for that

v1kku avatar Feb 22 '21 15:02 v1kku

@lociii what do you suggest?

auvipy avatar Feb 25 '21 08:02 auvipy

Sounds good to me. However this will be a breaking change as activity stream will stop working with JSON data field when the update is installed and django_jsonfield_backport is not added to the INSTALLED_APPS .

lociii avatar Feb 28 '21 19:02 lociii

go ahead and make a PR so we can see the solution

justquick avatar Feb 19 '22 19:02 justquick