django-activity-stream icon indicating copy to clipboard operation
django-activity-stream copied to clipboard

Django Sites usage with single-site projects

Open moorchegue opened this issue 6 years ago • 5 comments

Hi there! I'm considering using django-activity-stream for my project, it seems to fit perfetcly except one little hiccup — Django Sites framework requirement.

I noticed that django.contrib.sites is only being used in a couple of feed view methods. Would it be possible to only require Sites for projects that do have multiple sites (i.e. already have Sites installed) and for simpler projects use domain information from the request?

moorchegue avatar Oct 01 '18 16:10 moorchegue

Also for the multiple-site projects there're alternative approaches (e.g. http://niwinz.github.io/django-sites/latest/) and it would be nice to not have to use a single package but have some flexibility. Although this is not my problem currently, just a thought.

moorchegue avatar Oct 01 '18 16:10 moorchegue

I guess that's a no then :smile:

moorchegue avatar Feb 20 '22 04:02 moorchegue

Oops closed by mistake

justquick avatar Feb 20 '22 18:02 justquick

Hi!

I'm also interested in this feature. @justquick, would you be open to a PR?

Thanks,

Guillaume

glibersat avatar May 24 '22 07:05 glibersat

yes please PR any ideas

justquick avatar Aug 07 '22 13:08 justquick