justpy icon indicating copy to clipboard operation
justpy copied to clipboard

Outdated version of Quasar when served with NO_INTERNET

Open rodja opened this issue 2 years ago • 9 comments

JustPy still provides the outdated Quasar 1.9.14: https://github.com/elimintz/justpy/blob/72f94a9f1e7fcd2734b3c947ba2e830387083698/justpy/templates/local/quasar.js#L2.

The latest Quasar version is 2.7.7 which has many more features and bugfixes. I suggest we update the locally provided Quasar to the latest stable version.

rodja avatar Aug 27 '22 05:08 rodja

@elimintz have you just copied the files as generated by https://quasar.dev/start/umd? Is that the right approach for an update?

rodja avatar Aug 27 '22 06:08 rodja

e.g.

wget https://cdn.jsdelivr.net/npm/[email protected]/dist/quasar.umd.prod.js

WolfgangFahl avatar Aug 27 '22 13:08 WolfgangFahl

How would i activate NO_INTERNET in a test? I have added quasar_example from the tutorial to examples/tutorial

WolfgangFahl avatar Aug 27 '22 13:08 WolfgangFahl

Quasar version 2 works only with Vue 3 and justpy uses Vue 2 so we have to use version 1 of Quasar. However, the good news is that when a feature is added to Quasar 2, it usually find its way to Quasar 1 also. I guess many projects that use Quasar are in the same situation as us.

So we should provide the latest Quasar 1 version which is 1.19.5

elimintz avatar Aug 27 '22 13:08 elimintz

@elimintz What would it take to port JustPy to Vue 3? Are there any benefits or is it just very incompatible?

rodja avatar Aug 27 '22 15:08 rodja

The Vue components for me were the most difficult things to develop by far. I went through several design iterations. Justpy uses Vue in an original way, that as far as I can tell, no one used before.

This is the list of breaking changes between Vue 2 and Vue 3: https://v3-migration.vuejs.org/breaking-changes/

After reading it, I decided that I didn't have the appetite to take on the migration effort since for almost all users, they will not notice any difference. and it would be a very time consuming effort.

elimintz avatar Aug 27 '22 16:08 elimintz

Ok. What do you think about the Vue 3 migration build? It looks like we may run Vue 2 code on Vue 3 with this...

rodja avatar Aug 27 '22 16:08 rodja

Not sure this is an option for us because we don't build the application, justpy templates download the cdn version.

elimintz avatar Aug 27 '22 16:08 elimintz

For milestone 0.7 it would be good to have the latest compatible version.

WolfgangFahl avatar Sep 07 '22 06:09 WolfgangFahl

see #685

WolfgangFahl avatar Sep 20 '23 12:09 WolfgangFahl