justmara

Hmm, it is [unchanged](https://github.com/dotnet/orleans/commits/dad62cc16d4d6de671563f6b1e54196f617926a5/src/OrleansProviders/Streams/Common/SimpleCache/SimpleQueueCache.cs) since 2017, but used in Azure Queue, GCP, AWS SQS stream providers...

I didn't say if its correct, but only that it is widely used without any issues and maybe in real world scenarios (inside Orleans scheduler) all these races you're talking...

From my side i can tell that we're running forked version of your provider (with fixed compatibility for 2.3+ and SimpleQueueAdapterCache) for about 2 or months on production under load...

Ahh, I remember [another one](https://github.com/zitmen/Orleans.Streams.RabbitMqStreamProvider/pull/5/commits/7c0da2f01e3dc5fa7e47d6c199193e512acf01a6#diff-2825323a7fab9e1b66290926eee996f1L43) modification we've made - that stupid 'fix', because did not have time to dig deeper to its root. Without this it were delivering only to...

Re-checked that `ShouldDeliver` - now it works fine so I removed our `fix`. Passing tests locally, but appveyor still fails :( Also passing all tests fine even with higher message...

We use a bit different approach with extension like this: ``` public static JobBuilder UsingJobData(this JobBuilder builder, params (Expression expression, object value)[] setters) { foreach (var setter in setters) {...

I've dug a bit into it and looks like MessagePack formatter is very [simple](https://github.com/neuecc/MessagePack-CSharp#low-level-api-imessagepackformattert): ``` public class SkuIdMessagePackFormatter : IMessagePackFormatter { public void Serialize(ref MessagePackWriter writer, SkuId value, MessagePackSerializerOptions options)...

Also there is very interesting [MemoryPack](https://github.com/Cysharp/MemoryPack) that I wanted to try out, but it uses its own roslyn generator and it fails even building project where it and vogen are...

Тогда либо выдавайте BadRequest на невалидные суммы, либо валидно приводите к целым копейкам. Сейчас же вы молча проводите транзакцию по некорректным данным с непредсказуемым результатом.

@al-dr > На самом деле приводится корректно, согласно правилам округления. Конечно, если считать правильным HALF_EVEN, то всё _правильно_. А с точки зрения клиента - происходит списание на сумму большую, чем...