Dovid Levine

Results 315 comments of Dovid Levine

Hey @federikos - wondering if you ever resolved this issue? If not, can you please share a replicable test case (i.e. the code to register the CPT and the custom...

@federikos if you're still running into this problem please comment here and we'll reopen.

Filter for reverting. Needs testing that it catches all use cases, since we're we cant directly overwrite the constructor param passed to the resolver, only overwrite the `post_type` query arg...

Should this PR do the same for `termNodes`? Currently they return terms from _all_ taxonomies, and not just from `public` terms.

> We can still expose them in the Schema if they are show_in_graphql => true but just leave them out of the "public facing" ContentNode / TermNode interfaces? 🤔 I...

[Written before your last commit/comment. Reviewing that now] @jasonbahl thanks for the clarification > Seeing that you could query { contentNodes { nodes { ...someFields } } } and the...

Agree with the issues you raise, and that this is essentially a naming things issue more than anything else. >What I think we need to figure out, is GraphQL Type...

> Here's an idea: > > public post type: ContentType / ContentNode > > private post type: PrivateModel / PrivateModelType > > all post types: Model / ModelType > >...

Regarding using `ContentType` or `ContentNode` as either public-facing post types _or_ post types with a specific subset of fields, it seems WordPress core disagrees > There are many different types...

> Public Post types have a uri and should be ContentNodes. > ... > All Post Types could be DataNode / DataType The more we talk and I think about...