Dovid Levine

Results 315 comments of Dovid Levine

I believe I've backported everything I can without creating an impossible mess of merge conflicts. As @jasonbahl reviews/merges the existing PRs, I'll be able to start reviewing more. You can...

The next batch of backports is up, focusing on improving DX and instantiating class properties only once: - #3120 - #3121 - #3122 - #3123 - #3124 - #3125 Once...

Hey @stevepepple any chance you're still running into this in the latest versions of WPGraphQL (v1.21.0 as of writing, but keep in mind WPGatsby hasn't been updated in a few...

Looks like there's a path forward on this as of WP 6.4: https://make.wordpress.org/core/2023/10/24/framework-for-storing-revisions-of-post-meta-in-6-4/

> I think we can ship both versions (for a period of time), with the new one under a flag (filter) while we iterate, then switch it to be the...

@jasonbahl I might be misunderstanding the API and/or misusing the terminology so bear with me 😅 - Lazy-loaded types: both interfaces and their resulting children don't always appear in GraphiQL...

> I believe we might be able to somehow identify if the query being made is an introspection query, and if it is, let the value of eagerlyLoadType be what...

> As discussed with @jasonbahl we'll need to provide a filter to revert the name change on this Type for those affected by this breaking change with the release. >...

I like @jasonbahl 's suggestion too, that way we can continue to iterate on the new type without getting held up by back-compat. Speaking in broad terms, I suggest we...

@moonmeister would you mind fixing the phpcs / phpstan issues? > I have not written any tests, I can work on them if they're needed. Looks like we're going to...