quickjs-emscripten
quickjs-emscripten copied to clipboard
`encodeBinaryJSON`, `decodeBinaryJSON` error handling and flags
Hi, thanks for this lib. I'm working on small improvements to encodeBinaryJSON and decodeBinaryJSON:
- Return a
QuickJSContextResult<QuickJSHandle>instead of aQuickJSHandle, to surface any errors. - Accept flags and pass them through, instead of hardwiring
JS_WRITE_OBJ_REFERENCEfor encode and no flags for decode.
I've noticed that there are a few PRs open and not much activity in recent months, so before I open a new PR I just wanted to check to see if you're interested in these improvements? If so we'd also have to discuss backward compatibility.
If you open a PR, I'll merge it if the tests pass :)