robut
robut copied to clipboard
justinweiss
Weather Plugin
Since the Google Weather API has been gone for quite awhile now, I've recently begun work on a Wunderground based replacement. My question is, if I want to submit it back, would you prefer it be a separate plugin module like you have some of them now, or would you want a fork and pull request to simply update the existing one?
That's a great idea, thanks for looking into it!
A separate gem would probably be best, but I'd like to do a better job of highlighting gem plugins. Let me know what you come up with and I'll add it to the readme, with installation instructions.
On Nov 4, 2013, at 6:34 AM, Richard [email protected] wrote:
Since the Google Weather API has been gone for quite awhile now, I've recently begun work on a Wunderground based replacement. My question is, if I want to submit it back, would you prefer it be a separate plugin module like you have some of them now, or would you want a fork and pull request to simply update the existing one?
Reply to this email directly or view it on GitHub.
When I'm done, I'll note it here. Would you like a pull request at that point to remove the existing weather plugin and the references to it in the Chatfile documentation/readme/etc?
Yeah, that would be great. Thanks!
On Nov 4, 2013, at 7:13 PM, Richard [email protected] wrote:
When I'm done, I'll note it here. Would you like a pull request at that point to remove the existing weather plugin and the references to it in the Chatfile documentation/readme/etc?
— Reply to this email directly or view it on GitHub.
As promised, I've made it into a gem. I'm not going to push through a pull request (yet) to update your documentation and stuff because:
A. I've been having a hard time getting tests to run on robut itself due to the rdoc changes. I don't want to break anything accidentally. B. I don't necessarily want to have you promote something that no one (beyond me) has really tried yet.
So, @justinweiss, if you (or anyone else) wants to take a look, please feel free. https://github.com/richard4339/robut-weather
Could you go into more detail about how the tests are failing? They're working for me. I pushed a minor fix to the mocha support that was causing some problems.