Clean Up

Open faruzzy opened this issue 8 years ago • 3 comments

NodeList implements a forEach method. So no need to wrap it inside of another array for that purpose. I also took the liberty to remove unused 'event' variables

Nov 12 '17 07:11 faruzzy

This looks great, thanks!

One note: it seems like your clean up changes from the last PR are in this branch again.. do you mind rebasing your branch off of master so this only includes the foreach redundancy and event argument removal? Thanks!

cc @srdjanm88 give it a 👀 if u have time

Nov 13 '17 01:11 justinthec

👍 Looks good to me - just give it a quick rebase and we'll merge it in.

Nov 13 '17 18:11 s-km

Cool will look into this!

Nov 17 '17 18:11 faruzzy