hybrid icon indicating copy to clipboard operation
hybrid copied to clipboard

Published 20 hours ago • verified publisher icon justintadlock

Major version bump expected for removed functions

Open ryanve opened this issue 10 years ago • 2 comments

I just updated Hybrid from 1.1 to 1.2 on my friend's website which uses a Skeleton-based theme and got PHP warnings on his homepage for meta functions no longer existing which I then had to fix.

  • hybrid_meta_robots
  • hybrid_meta_author
  • hybrid_meta_keywords
  • hybrid_meta_description

I guess I should have been function_exists checking them first. Based on semver I'd expect they'd exist until a MAJOR version change.

ryanve avatar Apr 27 '14 20:04 ryanve

Technically, 1.1 to 1.2 is a major version change. This theme doesn't follow the Semantic Versioning system. It follows the versioning system that WordPress uses. However, I do have plans to move toward using Semantic Versioning in all of my future projects. I'm not sure that I'll do it for old projects such as this theme yet, but I'll leave this ticket open for now.

justintadlock avatar Apr 28 '14 03:04 justintadlock

Gotcha. Using semver is wise. Most developers expect it I think. WordPress seems isolated from the greater development community. Is the WordPress versioning system documented online?

ryanve avatar Apr 28 '14 19:04 ryanve