Justin Permar

We can't use Finagle with AWS ALB unless this is fixed. It's a blocker for us. I can probably devote time to fixing this if anyone would be kind enough...

@mosesn As noted above, HTTP 1.1 spec requires valid Host header. We're making requests with Finagle to AWS ALB, which rejects the requests with 400: https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-troubleshooting.html#http-400-issues.

@mosesn Ah I see what you're asking now. Yes, setting the host header is a workaround for our use case (I'm currently in the process of testing our application with...

+1 on this PR. I was just about to start working on this one myself when I found this PR. So thank you for your efforts!

is it important that netty-tcnative-boringssl-static dependency is not shaded? I'm unclear on how netty searches the classpath at runtime to find this... update: yes, it's important (see below)

As you guys already noted, with the shaded jar, Pushy exposes netty classes in a different package, thus breaking source compatibility for users. Consequently, imo this PR needs to expand...

I updated the shade configuration as follows: ``` org.apache.maven.plugins maven-shade-plugin 3.1.0 package shade io.netty:netty-tcnative-boringssl-static io.netty com.turo.pushy.external.io.netty io.netty.internal.tcnative.* io.netty.util.internal.NativeLibraryLoader io.netty.util.internal.NativeLibraryLoader$NoexecVolumeDetector io.netty.util.internal.NativeLibraryUtil io.netty.util.internal.NativeLibraryLoader$1 io.netty.util.internal.NativeLibraryLoader$2 com.google.gson com.turo.pushy.external.com.google.gson com.google.code.gson com.turo.pushy.external.com.google.code.gson org.apache.commons com.turo.pushy.external.org.apache.commons org.slf4j com.turo.pushy.external.org.slf4j...

Also, users will need to exclude the dependencies from the shaded jar, as the default POM is published to maven (and used by clients) (and the default POM lists the...

FWIW, I have a project that uses Pushy and Twitter Finagle (which also uses Netty). I am able to compile my project and run everything successfully with the shaded jar...

+1 from a user who would benefit from this enhancement!