Justin M. Keyes

Results 2414 comments of Justin M. Keyes

I understand now. > the root directory for oxlint is monorepo-starter/packages/hono-starter, but since there is no .oxlintrc.json file there but looking at the logic of https://github.com/neovim/nvim-lspconfig/blob/46434074f188e6bfccf9d9153dd8be6b1381498b/lua/lspconfig/util.lua#L47 , it would only...

no, it searches in-order: https://github.com/neovim/neovim/blob/b877aa34cf366982bf92aa8b17a8409a1f8eb134/runtime/lua/vim/fs.lua#L304-L305

oh good point. that's wrong. it's contrary to the behavior of `root_markers`, which searchs "depth first": https://github.com/neovim/neovim/blob/b877aa34cf366982bf92aa8b17a8409a1f8eb134/runtime/lua/vim/lsp.lua#L726-L731 so to avoid confusion, we should change the behavior of `insert_package_json` to match...

re 89515304e4eb81ff9eb65f3a582136fc658de139 > Because `uv_os_getenv` requires allocating, we must manage a map (`envmap` in `env.c`) to maintain the old behavior of `os_getenv` That `envmap` should probably be dropped. It is...

> I do not think there is any need to _add_ this feature. It would be good to _enhance_ existing one: Vim is capable of storing some variable values in...

> Otherwise you need to invent lockfiles or something like this Well, we have a IPC mechanism (sockets) that can allow all Neovim processes to communicate...

@realh UIs can, of course, connect to remote nvims across a network already, and local nvims can send commands to remote nvims. Whatever (network) connection used by the UI to...

> How about cmdwin completion? Do you mean we should `:setlocal completeopt-=noselect` in cmdwin, so that `:s` selects an item in cmdwin?

> BTW, this may lead to a lot of test conflicts with #30189 :( `popupmenu_spec.lua` specifically? I can wait until after that PR. If the cmdwin change is a blocker,...

> So maybe it should defaults to "noinsert" instead of "noselect"? Does that work well for you with `vim.lsp.completion` ? AFAIR it did not.