Justin M. Keyes

Results 2414 comments of Justin M. Keyes

That does look nice. A concrete plan will help someone to resolve this. Should we introduce 'statuslineheight' which supports string values such as `"100%"` (percent) and `"2"` (rows)? Percent introduces...

Many `root_pattern()` usages can be eliminated after: - https://github.com/neovim/neovim/pull/33771

Not sure about this, but - Should be mentioned at `:help q` and related places. - closes https://github.com/neovim/neovim/issues/24475

I think deleting buffers/windows is disallowed in some events. Perhaps we should add that restriction to these events, to start with.

> Note: after this PR there is a new way to crash Nvim: Using `aucmd_defer` from https://github.com/neovim/neovim/pull/35793 should avoid that. > @justinmk, any update on relevance of this particular PR?...

Opinions on naming this `MacroEnter` instead? There are currently no help tags for "replay" at all, and only one match for "replay" in repeat.txt. Vim calls the concept "recording" but...

> Using `aucmd_defer()` will defer until the end of the macro Can we defer input processing also? Also, what happens if the `MacroEnter` handler itself calls a macro? Need a...

> Maybe the command shouldn't support trailing bar and comments as well? Is that because `|"` might be needed for some args? > And for "only accepting one client name"...

> list all lsp-clients globally or buffer-locally That is a job for `:checkhealth vim.lsp` (which does need some improvements to better show the "current buffer" state). Besides rebasing, this PR...

> Add tests (but where?) `./test/functional/ex_cmds/lsp_spec.lua` or `./test/functional/plugin/lsp_spec.lua`. Doesn't need to be deep, just 1-2 tests that exercise the codepath.