Justin M. Keyes

Results 2414 comments of Justin M. Keyes

> customize `vim.lsp.buf.code_action()` to show the name of the language servers Why don't we do this by default? Seems like a reasonable default behavior.

The configs in this repo are provided as a starting point. We depend on users (like you) to troubleshoot issues with their specific LSP setups and [send improvements](https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#adding-a-server-to-lspconfig).

This looks great, let's get it merged. > 2\. Updated treesitter highlighter to use `on_range` instead of `on_line`. This improves performance for long lines, as query cursor doesn't have to...

> * Users should be able to see workspace diagnostics either via the [file explorer](https://github.com/neovim/neovim/issues/32280) or in quickfix list > * There should also be a function that returns workspace...

> need a new `vim.lsp.workspace_diagnostics()` nit: all of our current workspace-related functions are in `vim.lsp.buf`. The new one should go there too (or in `vim.lsp.diagnostic` ?), though it probably makes...

At least one advantage of the comment is that user can use `gf` to visit the $VIMRUNTIME path mentioned there. That's the entire point. And if the comment has example...

any code re-use possible here? either old code can use these APIs, or vice-versa...

> `nvim_buf_set_text` and `nvim_buf_set_lines` are not "regular edit operations". They are APIs, which should at a lower-level than regular edit operations. That's a fair point. I see also that `setline()`...

`nvim_buf_set_lines` currently returns void. It could return a dict containing the modified region (see https://github.com/neovim/neovim/issues/31903 ). That allows plugins to easily set the `'[` `']` marks if they want.

Side-note: should we define and document "popups" as "unfocusable windows"? https://github.com/neovim/neovim/pull/34207#discussion_r2112045760