Justin M. Keyes

Results 2414 comments of Justin M. Keyes

Wow, didn't know about this vscode feature! This definitely looks useful. Thanks for pointing to the upstream docs too.

> there are a lot of places in the neovim ecosystem and the built in lsp client and utilities, that are using the `get_name` api, instead of `expand(%)`, the way...

`VimEnter`/`VimLeave` are working afaict, which isn't surprising since we are literally just starting a new `nvim` process. The open question is whether scripts need to know specifically that "restart" is...

I suggest waiting on that until a followup PR. It shouldn't block this one. The only tiny blockers here are - https://github.com/neovim/neovim/pull/33953#discussion_r2119536946 - add a news.txt item Added missing docs...

> there's a best practice for testing the images themselves. I can verify that we write escape codes to a terminal in a format that we expect. I don't know...

> Considering the additional complexity for supporting it, as well as the apparent feature gap mentioned here, I'd propose implementing support only for the kitty graphics protocol first SGTM. The...

> @justinmk where did we align on keeping/removing iTerm protocol support? And sixel support? > > My perspective is that we figure out a good interface for new backends (like...

@fredizzimo those are great notes, would you mind creating a new issue to track that as "phase 2"? > 7\. I think the image data and rendered instances should be...

@fredizzimo your PRs aren't being ignored, I'm trying my best to attend to everything and prepare for the 0.11 release. I asked you to create an issue so your notes...

@chipsenkbeil in item 1 of your list, should [items 7/8 from fredizzimo's list](https://github.com/neovim/neovim/pull/31399#issuecomment-2708860495) be part of that (this PR)?