Justin M. Keyes

> 1. I dont see yet a hackable/extensible plugin (lua functions usable by user) which offers the following functionality based on filepaths and integrates well into for example harpoon or...

> It doesn't seem like a good idea to hardcode a particular text representation. We can easily add a parameter for that. Doesn't need to block an initial "best effort"...

> What the motivation for doing something so new and underdeveloped directly in core? The core parts of this feature are generally useful. The path to getting this feature will...

> Isn't it an "overkill" to add the amount of (sensitive) changes to fix an --after all-- small issue? I wouldn't say https://github.com/neovim/neovim/issues/32550 is a small issue. It's pointing to...

Maybe we should also have a test for `vim.uv.os_unsetenv` (the repro steps from https://github.com/neovim/neovim/issues/32550 ) in `test/functional/` (not `test/unit/`)? May need a new `test/functional/core/env_spec.lua` file.

> Once all approved, I'm squashing the new commits into 1st one (and of course do a rebase at that point as well :-) ) no need since you merged...

> Functional test added as requested was it pushed? don't see it

> yes, but this will call parse_snippet twice why? can a optional param be added to `get_doc`? it's more important to group logic in one place, then can optimize it...

I am confused by the latest changes. Looks like more code, and `get_doc` wasn't re-used.

It's a local function, in a small scope (one module), meant to capture related logic in one place. Focus on simplifying the logic, ignore the name for now. I can't...