Justin M. Keyes

Results 2414 comments of Justin M. Keyes

> I have been running the branch of the PR since it was created, have zero issues. Thank you! That is valuable to know. Why again was `commands` renamed to...

"API resemblance" here means "it literally matches `nvim_create_user_command` ? This is questionable because: 1. `nvim_create_user_command` itself is probably over-specific and should have been named `nvim_create_command` (if ever it becomes theoretically...

Looking closer, and reviewing https://github.com/neovim/nvim-lspconfig/pull/1838 , I see that a migration will be required anyway, because the command structure changed. I wonder if instead we should maintain the old interface....

> Perhaps we remove the interface for user to define the commands, seeing as they could just use `nvim_create_user_command` where appropriate. I'm in favor of that. We would need to...

similar to https://github.com/neovim/nvim-lspconfig/pull/2013

CI failures need to be fixed

how is the lsp server supposed to work without a project file?

same problem would then occur if `.git` is not found. general question for all configs: why don't we fallback to `vim.fn.getcwd()` ?

Thanks for your report. The configs here [are best-effort](https://github.com/neovim/nvim-lsp#nvim-lsp): > It is hoped that these configurations serve as a "source of truth", but they are strictly best effort. If something...

# Status https://github.com/neovim/nvim-lspconfig/issues/1683#issuecomment-1020997746 : > Here are some concrete suggestions: > > * Ensure single_file_support is disabled and special case the root pattern in ALS to ignore system libraries to...