efficient-programming-with-components icon indicating copy to clipboard operation
efficient-programming-with-components copied to clipboard

Change code block style

Open justinmeiners opened this issue 2 years ago • 2 comments

  • no more background color.
  • all blocks are indented.
  • fix #53

@aharrison24 any opinions?

justinmeiners avatar Jan 02 '22 23:01 justinmeiners

I do like the indenting. My initial reaction to the background change is that things look a bit 'stark' now. Though I admit am conditioned by the way that GitHub and Slack do things -- I'm used to some sort of box denoting a code block.

Ultimately I don't feel particularly strongly, but I'd probably come down on the side of having more than just a font and indent change signifying that something is a piece of code. I'm not sure what your underlying reason for the change is, so it's a bit hard to suggest good alternatives.

The existing grey blocks are certainly a bit ugly. Would it help to prettify them a bit? Both GitHub and Slack have nice rounded corners on the code blocks. Slack uses just a thin grey border and leaves the background colour untouched. Could something like that work?

Screen Shot 2022-01-04 at 20 59 25

aharrison24 avatar Jan 04 '22 21:01 aharrison24

Thanks for the feedback. You and @rpendleton think alike.

justinmeiners avatar Jan 06 '22 02:01 justinmeiners