greenstalk icon indicating copy to clipboard operation
greenstalk copied to clipboard

Published 20 hours ago • verified publisher icon justinmayhew

Tests failing on beanstalkd master branch

Open SamMousa opened this issue 2 years ago • 2 comments

Hey, I've been working on a PR to run test suites of beanstalkd clients on pushes to the beanstalkd source code. (The PR is not yet merged: https://github.com/beanstalkd/beanstalkd/pull/614)

I'm posting this here since greenstalk tests will fail as soon as a new beanstalkd version is released:

https://github.com/SamMousa/beanstalkd/runs/4712188954?check_suite_focus=true

SamMousa avatar Jan 05 '22 09:01 SamMousa

Hi there, I think you meant to link to this.

It looks like the tube name now has double quotes surrounding it. The "YAML" parser in this library is super naive so it's not a surprise that something eventually broke.

Thanks for opening this issue.

justinmayhew avatar Jan 05 '22 15:01 justinmayhew

It looks like the tube name now has double quotes surrounding it.

Yeah it's definitely that, that's the change I authored that got merged.

SamMousa avatar Jan 05 '22 15:01 SamMousa

Fixed in commit 5f4f42438d102037102da4f1e1c207617cc4ed41.

justinmayhew avatar May 27 '23 15:05 justinmayhew