django-autoslug icon indicating copy to clipboard operation
django-autoslug copied to clipboard

Add type information

Open fabiommendes opened this issue 3 years ago • 4 comments

This PR implements a minimal typing support to make Autoslug work with Mypy

fabiommendes avatar Dec 23 '22 20:12 fabiommendes

Hello @justinmayer

Do you want to integrate this or prefer a stub on typeshed (which I'm preparing now for local development)?

msopacua avatar Oct 20 '23 12:10 msopacua

@fabiommendes: Thank you for the pull request submission. My apologies for the delay in responding. Would you be so kind as to review the suggestions that @msopacua made and update your changes as appropriate?

@msopacua: Many thanks for your sponsorship, which is deeply appreciated. And thank you for your assistance with reviewing this pull request. I think integrating the type information makes sense. ✨

justinmayer avatar Oct 20 '23 15:10 justinmayer

@justinmayer You're very welcome. I've been using this library on and off since 2014 or so? So about time :)

msopacua avatar Oct 20 '23 17:10 msopacua

It's so cool to see confirmation that the library is still useful after all these years! Thank you for keeping it alive, @justinmayer :)

neithere avatar Oct 20 '23 20:10 neithere