sql-source-control icon indicating copy to clipboard operation
sql-source-control copied to clipboard

ssc init should default to port 1433

Open Jaxelr opened this issue 4 years ago • 0 comments

Describe the Feature

When running ssc init currently the default value for port is undefined, this causes the field to be NaN on display and Null on creation.

image

As i understand it, it would be a more pleasant UX to default to port 1433, which is the usual sql server default port.

image

Todo

Suggested Solution

The suggested solution is to on line 62 of the init.ts command file switch to 1433 the default value:

https://github.com/justinlettau/sql-source-control/blob/e487dfe4bea148282c4b7a9ce11c0fc8044666cd/src/commands/init.ts#L62-L66

Other Information

I can make the PR, but i wanted to discuss it first, in case there's some scenarios i am not considering.

Jaxelr avatar Feb 11 '21 20:02 Jaxelr