node-midi icon indicating copy to clipboard operation
node-midi copied to clipboard

Make native module context-aware

Open wookayin opened this issue 4 years ago • 2 comments

Electron 14.0+ requires the module to be context-aware to be importable.

Fixes #164 References: electron/electron#18397

wookayin avatar Nov 10 '21 05:11 wookayin

Thanks for adding support for new Electron versions.

When building with Electron 16, I'm getting this error: *** No rule to make target `Release/obj.target/midi/vendor/rtmidi/RtMidi.o', needed by `Release/midi.node'. Stop.

adammeyer avatar Jan 07 '22 18:01 adammeyer

I have opened a PR to do an overhaul of this library which includes an alternate solution to this (#228) As it doesn't look like there are any maintainers around to merge it, I shall be maintaining a fork which is 100% api compatible https://www.npmjs.com/package/@julusian/midi

Julusian avatar Oct 01 '22 10:10 Julusian