Justin Grant

Results 205 comments of Justin Grant

Thanks @sffc for including me. I'm pleased to see the careful thought that you're putting into this design. I'll add a few comments and questions based on my (admittedly limited)...

@sffc thanks so much for your thorough explanations above. It's much clearer to me now what you're trying to accomplish, and overall this seems like a good direction. > It...

> Hmm, I like calling it `ZonedDateTime`, but `FormattableZonedDateTime` could work. However, if the type doesn't have arithmetic functions, it's not like users could accidentally perform arithmetic with this type,...

> I feel like good docs can solve this problem, recommending a different crate if you need arithmetic. And ICU4X's ZonedDateTime is not _wrong_; it just doesn't support that one...

> Can you help me find `debug.log`? I assume it's somewhere in the container file system. @brbarnett Do you remember where you found this file?

Thanks @sffc for starting this conversation. I don't yet have an opinion about the best solution here, but I've got some initial questions/comments below. The main guidance I'd have (based...

> I'm definitely not in favor of returning any stable integer I don't know enough Rust to know if this idea is practical, but could the memory savings be achieved...

How many bytes does a string reference cost in Rust? Would a wrapped `u16` be cheaper?

I was assuming that the list of interned strings would be immutable and global so wouldn't need a reference to it. But this assumption might be wrong?

Oh, OK. If global caches are out of scope, then yes a cookbook example makes sense for this case, at least as a starting point to see if it's ergonomic...