dada-mail icon indicating copy to clipboard operation
dada-mail copied to clipboard

Rogue comma in invitation email subject

Open JohnAJ opened this issue 2 years ago • 2 comments

When an invite is sent out, the subject line is: -

You've been Invited to Subscribe to, "{list-name-here}"

The comma after the "to" shouldn't be there?

JohnAJ avatar Sep 09 '22 10:09 JohnAJ

That's how it's written in the template, so it should be there, in a very technical sense,

https://github.com/justingit/dada_mail_foundation_email_templates/blob/master/src/pages/invite_message.txt

If it needs to be in there, or should for whatever style of grammar being followed is certainly up for debate. If I was to follow I think what's being talked about here,

https://thecriticalreader.com/commas-names-titles/

I'd take it out.

justingit avatar Sep 09 '22 14:09 justingit

Thanks,

I hadn't realised the subject is taken from the .txt version of the template, so an easy change for me :)

FWIW I agree, it shouldn't be there grammatically.

JohnAJ avatar Sep 09 '22 15:09 JohnAJ