Justin Israel

Results 191 comments of Justin Israel

@walrusVision do you want to have a look at #130 ? I have opted to set a default pad char.

I can't say there has been any plan to create stubs at this point. Is there a specific benefit to generating and maintaining external type stubs for a pure python...

I would say that for a pure python library (vs a compiled extension), maintaining external type hints feels excessive. So I am inclined to go with either the legacy type...

Drop py2 support: #119

I can work on dropping py2 support this weekend. And we can add the marker file.

@johhnry do you want to review https://github.com/justinfx/fileseq/pull/129 and propose any changes?

I don't use MyPy. Just the standard checker/linter integrated into Jetbrains. I've never used MyPy so I am not sure if it is far more aggressive. If enabling this py.typed...

I've just pushed another commit that addresses all the errors reported by MyPy: https://github.com/justinfx/fileseq/pull/129/commits/86b078a375a279681d657b2ff7ec69230c46c33e Does that look right to you at this point? I would need to add a `mypy`...

I've added mypy type checking to the CI and merged to the v2 branch, which is being prepared to drop python2 support: https://github.com/justinfx/fileseq/actions/runs/7892283794