mixwith.js icon indicating copy to clipboard operation
mixwith.js copied to clipboard

Error if Symbol not defined.

Open trusktr opened this issue 8 years ago • 1 comments

https://github.com/justinfagnani/mixwith.js/blob/d34fe88ef3bb69d7e1751ad139208b656bf88a38/src/mixwith.js#L181

Seems that if Symbol is not defined, there will be an error. Maybe it needs to be a typeof Symbol != 'undefined' check.

trusktr avatar Apr 27 '18 08:04 trusktr

Oh, and

mixin[Symbol.hasInstance]

will check for Function.prototype[Symbol.hasInstance]. Should that check for an own symbol property instead?

trusktr avatar Apr 27 '18 08:04 trusktr