Justin Chu

Results 290 comments of Justin Chu

Linux getting `gmake: *** [Makefile:136: all] Error 2` (used to work) I wonder what it was...

I think it is ``` CMake Deprecation Warning at googletest/CMakeLists.txt:49 (cmake_minimum_required): Compatibility with CMake < 2.8.12 will be removed from a future version of CMake. ```

> I think it is > > ``` > CMake Deprecation Warning at googletest/CMakeLists.txt:49 (cmake_minimum_required): > Compatibility with CMake < 2.8.12 will be removed from a future version of >...

google test errors. Do we need to update googletest? ``` [ 50%] Building CXX object googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o In file included from /home/vsts/work/1/s/.setuptools-cmake-build/googletest/src/googletest/googletest/src/gtest-all.cc:42: /home/vsts/work/1/s/.setuptools-cmake-build/googletest/src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’: /home/vsts/work/1/s/.setuptools-cmake-build/googletest/src/googletest/googletest/src/gtest-death-test.cc:1224:24: error: ‘dummy’ may...

Need >1.11: https://stackoverflow.com/questions/69935158/dummy-may-be-used-uninitialized

This is because we are using a newer gcc with ubuntu 20.04

gmake[2]: *** No rule to make target 'googletest/src/googletest/googletest/libgtestd.a', needed by 'onnx_gtests'. Stop.

@jcwchen Reverted image versions. Now only macos is failing because of the not found protobuf compiler. Any idea how I can fix that?

I need to set an env var that is not PATH. Is there another var I can set?

@gramalingam @xadupre I kinda like how constraints for specified there https://github.com/openxla/stablehlo/blob/main/docs/spec.md