Justin Chu
Justin Chu
Please consider using the latest onnxruntime (1.12) (and if still doesn't work) and the latest PyTorch (1.12.1) version.
I would use a more descriptive PR title
@snnn With this test PR I am seeing a few checks that are particularly noisy / may not make sense (`onnxruntime::Tensor* tensor = nullptr = value.GetMutable();`) I am still learning...
> @snnn With this test PR I am seeing a few checks that are particularly noisy / may not make sense (`onnxruntime::Tensor* tensor = nullptr = value.GetMutable();`) > > I...
> Is the compile_commands.json file getting generated and passed to clang-tidy (-p option)? No since I wasn't sure what the best way is to generate it. Is there a command...
@edgchen1 that's a little more noise than what I hope it would produce! Should I turn off ``` misc-unused-parameters readability-convert-member-functions-to-static cppcoreguidelines-init-variables ``` for now? I am not sure why `cppcoreguidelines-init-variables`...
@edgchen1 looking good now (to me)
@edgchen1 I think that's because the lint is only checking diffs!
> as a side note, we'll probably need to generate a compile_commands.json file to configure clang-tidy properly. Absolutely. I haven't figured out how to do that though. @snnn any suggestions?
Current command `python tools/ci_build/build.py --build_dir build --update --cmake_extra_defines CMAKE_EXPORT_COMPILE_COMMANDS=ON`