Justin Chu comments

Results 290 comments of


                                            Justin Chu

ONNX export is unnecessarily slow (O(N^2))

All approved, please check PRs and adjust/rebase. Thanks!

ONNX export is unnecessarily slow (O(N^2))

Feel free to lmk when any of the open PRs are ready to merge. Thanks!

ONNX export is unnecessarily slow (O(N^2))

@gustavla When you are done updating the PRs, feel free to use pytorchbot merge to initiate the merge process. Thanks!

aten::squeeze exported to ONNX as an `If` node

I wonder if the `.setType()` method helps here?

Fix bfloat16 serialization for ONNXProgram.save

Resolved

[ONNX][dynamo_export] ONNX::Celu Half unsupported but export passed w/ invalid model when opmath disabled

Yes it falls under ONNX point 1. I am now inclined to have the converter examine opschema and insert casts for this case, because torchlib doesn’t have information on the...

[ONNX][dynamo_export] ONNX::Celu Half unsupported but export passed w/ invalid model when opmath disabled

What I understand is we don’t prefer always adding upcasts, but we will still need to cast when we actually need them (for onnx support). The current promotion logic doesn’t...

[ONNX][dynamo_export] ONNX::Celu Half unsupported but export passed w/ invalid model when opmath disabled

Happy to discuss further offline

首页布局错误

@tufu9441 我在尝试搞清楚问题的原因。 @thiswan 请问是回退到了 #125 之前（还原了 #125 的更改），还是刚好回退到 #125 ？ @imkerberos 请问网页显示的分辨率是多少？ #125 的更改是使得边栏在网页宽度窄的时候显示到页面底部，以往则是不显示。

首页布局错误

刚好退回到#125就显示正常，说明问题就应该不是 #125 导致的。可以检查一下较新的PR。不过我快速看了一下之后的commits，暂时还没有发现问题。