Justin Chu comments

Results 441 comments of


                                            Justin Chu

[Feature request] Make OpSchema writable from Python

I think that’s a great idea

[Feature request] Make OpSchema writable from Python

We will create a single constructor and allow only shape inference overrides instead

[Feature request] Make OpSchema writable from Python

https://pybind11-jagerman.readthedocs.io/en/stable/advanced.html#custom-constructors

[Feature request] Make OpSchema writable from Python

Documentation: FormalParameter

Shape inference errors on missing type when the input is static optional and omitted

I wonder if the condition is statically known, do it’s subgraph need to be all valid?

Shape inference errors on missing type when the input is static optional and omitted

Discussed with @gramalingam . We can use the new OptionalGetElement to solve this problem

Shape inference errors on missing type when the input is static optional and omitted

That sounds right. Thanks! With the new OptionalGetElement I think we no longer have this problem because the graph will be valid?

Shape inference errors on missing type when the input is static optional and omitted

https://github.com/onnx/onnx/pull/5022

Is there any API (in cpp or python) to extract the expression or subgraph of a "function"?

https://onnx.ai/onnx/api/defs.html#onnx.defs.OpSchema.function_body

Could I modify the Opschema after Register?

You may now use the https://github.com/onnx/onnx/blob/b590c5fef602d2ac2277c5b57c5818e976ce6d27/onnx/defs/schema.h#L1497 function starting from ONNX 1.16.