Possible improvement for method 'sorted_nicely'

[OshinoMoumou]

Greetings! I noticed that method sorted_nicely referred a StackOverflow post, while a recent comment to it noticed that it doesn't work for sorting sets of version numbers alphanumerically; e.g., v1.0.1, v3.5.3, v3.2.4. I'm trying to learn the usefulness of such small updates on StackOverflow. Would this comment help improve your code? I understand that might not happen in real life situation. In that case, do you think this comment can help prevent future defect (if the code were reused somwhere else)? I'll really appreciate it if you could kindly give me some feedback or suggestions. Thank you very much for your time. Have a nice day!

[justincc]

Hi @OshinoMoumou. Please could you be more specific as to what you're referring to in this codebase.

[OshinoMoumou]

Hi @justincc ! Sorry for the late reply. For method 'sorted_nicely' I mean the one in analysis/opensimulator-script-analyzer/src/ossa.py. I think it's supposed to sort real-life versions including those start with 'v', e.g., v1.0.1, v3.5.3, v3.2.4. However the comment I mentioned in the issue noticed that the method could fail in such case. Though that might not be a problem in your case, I'm studying on the usefulness of StackOverflow comments and noticed your reference. What I really want know is that whether you think this comment can help imporve the code. I'd be glad to know your opinion. Have a nice day :)