fluxcloud icon indicating copy to clipboard operation
fluxcloud copied to clipboard

Published 20 hours ago • verified publisher icon justinbarrick

Helm chart

Open emmekappa opened this issue 4 years ago • 5 comments

This PR will add an helm chart for fluxcloud.

It also supports helm repository automatic publishing to a github pages (thanks to this github action). In order to have this working an ACCESS_TOKEN should be added inside repository secrets as described here

emmekappa avatar Mar 28 '20 15:03 emmekappa

Welcome @emmekappa! It looks like this is your first PR to justinbarrick/fluxcloud 🎉

oliviabarrick avatar Mar 28 '20 15:03 oliviabarrick

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: emmekappa To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: justinbarrick

If they are not already assigned, you can assign the PR to them by writing /assign @justinbarrick in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

oliviabarrick avatar Mar 28 '20 15:03 oliviabarrick

Hi @emmekappa. Thanks for your PR.

I'm waiting for a justinbarrick member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

oliviabarrick avatar Mar 28 '20 15:03 oliviabarrick

I suggest 1) that the configuration, at least the SLACK_URL, be placed in Kubernetes secret and 2) that you allow the user to pass in annotations for the deployment.

The latter will allow the use of tools like reloader to restart the pods if the secrets change.

derrickburns avatar Mar 28 '20 16:03 derrickburns

hey @emmekappa we're continuing the development of his project here: https://github.com/topfreegames/fluxcloud Here's the reason for that #68.

We're happy to review your contribution there and help you to ship this feature.

marcosnils avatar Jun 27 '20 14:06 marcosnils