Justin Stephenson

Adding coverage analysis for `tlog-rec`, `tlog-rec-session`, and `tlog-play` requires getting integration tests merged and working in CI. Once completed, we can then add coverage analysis to determine gaps for writing...

Request to bump iOS deployment target for Xcode 14.X build

1

Hi, FreeOTP iOS https://github.com/freeotp/freeotp-ios fails to build moa as a dependency with Xcode 14.3 ~~~ ld: file not found: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_iphoneos.a clang: error: linker command failed with exit code 1 (use...

Request to bump iOS deployment target for Xcode 14.X build

1

Hi, FreeOTP iOS https://github.com/freeotp/freeotp-ios fails to build FontAwesome.swift as a dependency with Xcode 14.3 ~~~ ld: file not found: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_iphoneos.a clang: error: linker command failed with exit code 1 (use...

Wrong Check of Return Value Collapse ~~~ 1. Defect type: [NULL_RETURNS] 1. cockpit-session-recording/dist/index.js:437307: returned_null: "this.getCoords" returns "null" or "undefined" (checked 3 out of 4 times). 2. cockpit-session-recording/dist/index.js:437307: var_assigned: Assigning "coords"...

~~~ 1. Defect type: [FORWARD_NULL] 3. cockpit-session-recording/dist/index.js:447143: null_check: Comparing "matches" to a null-like value implies that "matches" might be null-like. 5. cockpit-session-recording/dist/index.js:447151: property_access: Accessing a property of null-like value "matches"....

~~~ 1. Defect type: [NO_EFFECT] 1. cockpit-session-recording/src/lib/qunit-tests.js:20: unused_expr: Discarding the programmer-written value ""use strict"". What was this code intended to accomplish? 2. cockpit-session-recording/src/lib/qunit-tests.js:20: remediation: Perhaps this code is incomplete or...

~~~ 1. Defect type: [COPY_PASTE_ERROR] 1. cockpit-session-recording/dist/index.js:352659: original: ""any"" looks like the original copy. 2. cockpit-session-recording/dist/index.js:352632: copy_paste_error: ""any"" looks like a copy-paste error. 3. cockpit-session-recording/dist/index.js:352632: remediation: Should it say ""wide""...

Misused Syntax Collapse 1. Defect type: [MISSING_BREAK] ~~~ 1. cockpit-session-recording/dist/index.js:436669: unterminated_case: The case for value "1049" is not terminated by a "break" statement. 3. cockpit-session-recording/dist/index.js:436671: fallthrough: The above case falls...

This will cleanup the look of the toolbar, removing the need for separate filter input boxes. https://www.patternfly.org/v4/design-guidelines/usage-and-behavior/toolbar