Justen Walker

Results 31 comments of Justen Walker

> @justenwalker can you tell me more about what you are trying to solve here? > > From Airbyte's pov, readiness and liveness checks are basically equivalent, since the server...

I've added tests for the indicators. I've also tried to implement the desired readiness check behavior. I'm not too familiar with the intricacies of Micronaut; so if there is a...

@davinchia > My suggestion is to keep the readiness/liveness code separation and have these still backed by the current health check handler. I believe this renders them useless - since...

@davinchia > I would actually argue database checks should be part of the readiness probe, since the server as currently written has this built-in assumption. We made sure the probe...

@davinchia I'll concede these points with regards to dependency checks in readiness probes: 1. If you are using readiness checks in place of startup checks to make sure the DB...

Some Updates to review: - @davinchia As requested, I removed the extra path I added for the `airbyte-webapp` component. I could probably make due with `/`. - @jdpgrailsdev I was...

@JonsSpaghetti > Hi @justenwalker, thank you for your contribution! We like what this change allows and discussed internally - our one question is: was there a reason a new column...

It's been almost a year with no activity. Is it difficult to add the work-around to grails-launcher?

@NeerajGartia21 @chivalryq If you run Docker Desktop, `/var/run/docker.sock` is no longer created. See: https://github.com/docker/for-mac/issues/6529 A work-around without needing to `sudo ln -s` is to explicitly set the `DOCKER_HOST` environment variable...