heap-buffer-overflow in /tsMuxer/bitStream.h:225:37 in BitStreamWriter::flushBits()

[gandalf4a]

Version

$ git show
commit 2539d074cd4da0547b97aedd8bc12252b973907c (HEAD -> master, tag: nightly-2023-10-05-01-55-56, origin/master, origin/HEAD)
Author: jcdr428 <[email protected]>
Date:   Wed Oct 4 10:17:02 2023 +0100

Platform

$ uname -a
Linux user-GE40-2PC-Dragon-Eyes 6.2.0-33-generic #33~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Sep  7 10:33:52 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

Asan

tsMuxeR version git-2539d07. github.com/justdan96/tsMuxer
HEVC muxing fps is not set. Get fps from stream. Value: 1
HEVC manual defined fps doesn't equal to stream fps. Change HEVC fps from 0.984375 to 1
=================================================================
==515802==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x603000020e1e at pc 0x55d8f3505d5c bp 0x7ffd609795b0 sp 0x7ffd609795a8
READ of size 4 at 0x603000020e1e thread T0
    #0 0x55d8f3505d5b in BitStreamWriter::flushBits() /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/bitStream.h:225:37
    #1 0x55d8f3505d5b in HevcUnit::updateBits(int, int, unsigned int) const /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/hevc.cpp:89:15
    #2 0x55d8f352cf28 in HEVCStreamReader::updateStreamFps(void*, unsigned char*, unsigned char*, int) /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/hevcStreamReader.cpp:373:10
    #3 0x55d8f37748c8 in MPEGStreamReader::updateFPS(void*, unsigned char*, unsigned char*, int) /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/mpegStreamReader.cpp:307:9
    #4 0x55d8f35256c3 in HEVCStreamReader::checkStream(unsigned char*, int) /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/hevcStreamReader.cpp:69:17
    #5 0x55d8f36bd699 in METADemuxer::detectTrackReader(unsigned char*, int, AbstractStreamReader::ContainerType, int, int) /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/metaDemuxer.cpp:785:22
    #6 0x55d8f36b0766 in METADemuxer::DetectStreamReader(BufferedReaderManager const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool) /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/metaDemuxer.cpp:685:35
    #7 0x55d8f35d5a7a in detectStreamReader(char const*, MPLSParser*, bool) /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/main.cpp:114:34
    #8 0x55d8f35e9efb in main /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/main.cpp:689:17
    #9 0x7fccd2829d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #10 0x7fccd2829e3f in __libc_start_main csu/../csu/libc-start.c:392:3
    #11 0x55d8f3370d24 in _start (/home/user/fuzzing_tsMuxer/tsMuxer/build/tsMuxer/tsmuxer+0x249d24) (BuildId: 93aa533ae68cbad6d874b6199ee386d19d3a575e)

0x603000020e1f is located 0 bytes to the right of 31-byte region [0x603000020e00,0x603000020e1f)
allocated by thread T0 here:
    #0 0x55d8f342ea4d in operator new[](unsigned long) (/home/user/fuzzing_tsMuxer/tsMuxer/build/tsMuxer/tsmuxer+0x307a4d) (BuildId: 93aa533ae68cbad6d874b6199ee386d19d3a575e)
    #1 0x55d8f3504f89 in HevcUnit::decodeBuffer(unsigned char const*, unsigned char const*) /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/hevc.cpp:41:19

SUMMARY: AddressSanitizer: heap-buffer-overflow /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/bitStream.h:225:37 in BitStreamWriter::flushBits()
Shadow bytes around the buggy address:
  0x0c067fffc170: fa fa fd fd fd fa fa fa fd fd fd fa fa fa fd fd
  0x0c067fffc180: fd fa fa fa fd fd fd fa fa fa fd fd fd fa fa fa
  0x0c067fffc190: fd fd fd fa fa fa fd fd fd fa fa fa fd fd fd fa
  0x0c067fffc1a0: fa fa fd fd fd fa fa fa fd fd fd fa fa fa fd fd
  0x0c067fffc1b0: fd fa fa fa fd fd fd fa fa fa fd fd fd fa fa fa
=>0x0c067fffc1c0: 00 00 00[07]fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c067fffc1d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c067fffc1e0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c067fffc1f0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c067fffc200: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c067fffc210: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==515802==ABORTING

Reproduce

./tsmuxer poc

POC File

https://github.com/gandalf4a/crash_report/blob/main/tsMuxer/poc_hbo_25

Credit

Gandalf4a

[jcdr428]

@gandalf4a not reproducible on Windows.

Edit: same under Linux Bulleye, all I have is:

./tsMuxeR poc_hbo_25
tsMuxeR version git-a5cc8ba. github.com/justdan96/tsMuxer
HEVC muxing fps is not set. Get fps from stream. Value: 1
HEVC manual defined fps doesn't equal to stream fps. Change HEVC fps from 0.984375 to 1
Can't detect stream type

[gandalf4a]

build reproduce

$ cd tsMuxer
$ mkdir build && cd build
$ cmake ../ -DCMAKE_C_COMPILER=clang  -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_FLAGS="-fsanitize=address" -DCMAKE_CXX_FLAGS="-fsanitize=address"
$ make 

Give me a second to see if windows can reproduce

[jcdr428]

I see... Ideally flushBits should be rewritten to flush byte per byte and not a full int only.