Justin Burkett

Results 171 comments of Justin Burkett

I don't think so. I introduced the keymap based replacements to avoid the overhead of processing the replacements alist (#261). Having which-key process the alist after the keymap based replacement...

> I don't see the point. If the regexp-based replacement alist is short enough it does not matter if it is applied always. Most of the simple replacements can be...

The current design can definitely be improved. The keymap replacements were added later and are much cleaner and faster under the surface, so I'd like to have people use those...

By default, which-key ignores bindings to `ignore`, but I see that general recommends this. It would be helpful to have some clarification from the general package on what exactly `:ignore...

Thanks everyone, and sorry for being absent (hard to find time these days)

Added a new function called `which-key-add-keymap-based-replacements` which like the `define-key` mechanism stores the information in the keymap itself, and allows one to avoid making `which-key-replacement-alist` very long. FWIW, I think...

Thanks @rgrinberg. I modified the README and added a couple of tests

I'm not very familiar with god-mode to start with, but after some basic testing it looks like god-mode breaks the basic emacs mechanism of using `help-char` to get help in...

Great, thanks for your work.

I asked a couple of questions about the changes a while ago and was waiting to hear back