Justin Burkett

Results 171 comments of Justin Burkett

Looking through the code, there was some unnecessary duplication of effort, so I deprecated `which-key-declare-prefixes`. It's actually just an alias for `which-key-add-key-based-replacements`. The functionality that the declare-prefixes function added was...

@terlar and @noctuid. which-key can easily support this if `(describe-buffer-bindings (current-buffer) KEY t)` showed `menu-item`s but it doesn't (at least how they are used here). That last argument suggests that...

@noctuid This commit (https://github.com/justbur/emacs-which-key/commit/f516b84eab1e307d3ffaa181324dca12c3951936) takes a partial step in that direction. If it works well, I can extend it. The idea is to pre-process arguments to `define-key` instead of taking...

I just ran into this. Here's a workaround ``` elisp (defun spacemacs/diminish-hook (_) (cl-loop for (mode uni nouni) in spacemacs--diminished-minor-modes do (diminish mode (if dotspacemacs-mode-line-unicode-symbols uni nouni)))) (add-hook 'after-load-functions 'spacemacs/diminish-hook)...

It is still obsolete. I submitted a pr to remove it from melpa, and I will ask to archive the repo (I can't seem to do it myself for some...

Can you take out the general stuff in your example? I keep getting errors (about general, nvmap, etc) trying to use your example.

Hm, I can't reproduce this. I just tried this from `emacs -Q` and everything seems fine with `h` and `l` ```elisp (package-initialize) (use-package magit :config (setq magit-popup-show-common-commands nil)) (use-package evil-magit...

This has been discussed and is a little more complicated than it first seems. I can give more details, but the main problem is that magit is basically line based,...

One thing I was thinking about would be to have `v` not shadow the selection/movement and other evil commands, and reserve `V` for selecting and operating on lines using magit...