magento2-sentry
magento2-sentry copied to clipboard
Compatibility with Magento Cloud
Hey guys!
I really like this extension I would love to use it on Magento cloud projects but I found a big blocker. You are using DeploymentConfig
to get all the configuration sentry settings. The problem with that is you are recollecting these options either from env.php or config.php. For on-premise projects is not a big issue to add all the settings into the env.php file but for Magento Cloud projects isn't possible.
Magento Cloud recommends using environment variables to override settings like CONFIG__DEFAULT__SENTRY__DSN
which in this case is not an option because the extension is using Magento Deployment Configuration.
I just forked your project and I would love to propose one of two solutions.
- Treat the settings as module configuration.
- Change the approach and accept environment variables as well.
What do you think?
It would be a good approach for Magento Cloud
I think treating the settings as module configuration would be the best approach to this because why would we read the environment variables manually when a more flexible solution already exists 😉
I would prefer the deployment config to still be allowed for backwards compatibility 🙂