vscode-factoriomod-debug icon indicating copy to clipboard operation
vscode-factoriomod-debug copied to clipboard

version name in mod directory

Open hahoyer opened this issue 4 years ago • 6 comments

When I create a modpackage the top directory has the modversion at the end of the name. This is actually no longer necessary and makes developing and debugging the mod more difficult. Is there a setting to change this?

hahoyer avatar Dec 20 '20 11:12 hahoyer

packaging is not involved in debugging, this question makes no sense

justarandomgeek avatar Mar 01 '21 20:03 justarandomgeek

Just asking if you could change function BuildZip in vscode-factoriomod-debug/src/ModPackageProvider.ts into :

public static async BuildZip(moddir:string,packagepath:string,ignore:string[],name:string,version:string): Promise<number> { const zipoutput = fs.createWriteStream(packagepath); const archive = archiver('zip', { zlib: { level: 9 }}); archive.pipe(zipoutput); archive.glob("**",{ cwd: moddir, root: moddir, nodir: true, ignore: ignore },{ prefix: ``${name}`` }); const bytesWritten = new Promise<number>((resolve,reject)=>{ zipoutput.on("close",()=>resolve(archive.pointer())); archive.finalize(); }); return bytesWritten; }

hahoyer avatar Mar 01 '21 20:03 hahoyer

It's not about debugging itself, it's about the things around it. If I want to debug a mod, I have to unpack it. If that's a different directory for each version, it's cumbersome. Either I still have to rename it each time or VSCode doesn't recognize that it's the same project.

hahoyer avatar Mar 02 '21 09:03 hahoyer

why is it packed in the first place if you're still debugging it? develop it in place as an unpacked folder in mods

justarandomgeek avatar Mar 02 '21 18:03 justarandomgeek

Oh, of course I debug and modify mods that I didn't develop myself. I thought that is clear and almost all work this way. But apparently this is not true. If it is apparently only my interest, then I can patch the place after each release. No need to change the product for that.

hahoyer avatar Mar 02 '21 18:03 hahoyer

Actually a lot of mods in the mod portal are not using the version-name in the prefix parameter anymore. Maybe you can think about it again and change it one day. It's really only a very small change.

hahoyer avatar Mar 02 '21 18:03 hahoyer