marshmallow-annotations icon indicating copy to clipboard operation
marshmallow-annotations copied to clipboard

Make changes to work with marshmallow 3.0+

Open mamikonyana opened this issue 6 years ago • 7 comments

These changes make marshmallow-annotations work with marshmallow 3.1 on my project.

Let me know if anything else needs to be tested.

mamikonyana avatar Dec 02 '19 18:12 mamikonyana

Pull Request Test Coverage Report for Build 121

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-97.5%) to 0.0%

Totals Coverage Status
Change from base Build 119: -97.5%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

coveralls avatar Dec 02 '19 18:12 coveralls

Pull Request Test Coverage Report for Build 111

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 110: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

coveralls avatar Dec 02 '19 18:12 coveralls

Addressed #7

mamikonyana avatar Dec 02 '19 18:12 mamikonyana

anyone could take a look at this pr ? or is the repo still active maintained?

feng-tao avatar Oct 20 '20 00:10 feng-tao

Sorry, my personal life became complicated and I've been away from OSS for a few years. Taking a look at this now. :/

justanr avatar Jan 28 '21 17:01 justanr

@mamikonyana this looks good to me at first glance and the tests pass (still!) if you're still wanting to merge this in, we'd just need to fix the conflicts (I can handle the bump version stuff locally) -- feel free to add a CONTRIBUTORS.md file as well! If you're not available to handle this PR, lemme know and I can manage getting it merged it (even if you're not available for that, I'd like to add you to a contributors section regardless if you're comfortable w/ that)

Edit: not a new contributors file, but to the authors file. :facepalm:

justanr avatar Jan 28 '21 17:01 justanr

@justanr fixed the conflicts, merges cleanly into master now.

mamikonyana avatar Jan 29 '21 13:01 mamikonyana