ddev-drupal-core-dev icon indicating copy to clipboard operation
ddev-drupal-core-dev copied to clipboard

feat: Allow installing and testing with all database types, including MariaDB

Open rfay opened this issue 1 year ago • 8 comments

(Draft: This has to be rebased after

  • https://github.com/justafish/ddev-drupal-core-dev/pull/33
  • https://github.com/justafish/ddev-drupal-core-dev/pull/31

This PR allows using any database type supported by DDEV, including MariaDB and MySQL. And of course it can still use sqlite.

It currently includes unmerged PRs because drush is required for it.

I guess it still needs tests, will wait until after rebase.

rfay avatar May 02 '24 17:05 rfay

@rfay Could you rebase this against main please? There are a lot of conflicts and I don't know what I'm doing with the code involved.

joachim-n avatar Oct 02 '24 16:10 joachim-n

I can rebase this and https://github.com/justafish/ddev-drupal-core-dev/pull/33, but it will still be dependent on https://github.com/justafish/ddev-drupal-core-dev/pull/33

rfay avatar Oct 02 '24 16:10 rfay

Ah drat, I hadn't seen this depended on #33. Too many balls in the air, sorry!

joachim-n avatar Oct 02 '24 16:10 joachim-n

I don't know if in my fork I want to support both styles of installation, or just using my Composer project template. I was initially thinking I'd support both, if it's not too much faff.

joachim-n avatar Oct 02 '24 16:10 joachim-n

This is rebased against

  • https://github.com/justafish/ddev-drupal-core-dev/pull/33 which was already up-to-date.

But of course it still depends on #33.

rfay avatar Oct 02 '24 18:10 rfay

I don't know if in my fork I want to support both styles of installation, or just using my Composer project template. I was initially thinking I'd support both, if it's not too much faff.

All I care about here is using a "normal" database type, and having drush available. I'm pretty sure your template is a fine way to do that, true?

rfay avatar Oct 02 '24 22:10 rfay

Yup, but what I mean is if I drop support for running this directly in a Drupal core clone, then none of #33 is needed.

joachim-n avatar Oct 02 '24 22:10 joachim-n

Again, any way you get drush works for me :)

rfay avatar Oct 02 '24 22:10 rfay