Sally Young

Results 56 comments of Sally Young

Is it worth revisiting #1641 ? @hegemonic would you be happy going forward with just removing requizzle, without the other refactoring mentioned in your response?

@mateu-aguilo-bosch As discussed in IRC, there should already be template caching. If you watch your console logs you'll see it only fetches them once. Are you seeing this behaviour now?

@q0rban Do you have any information on what the errors actually are?

Do you mean a display mode that can be used on spreadsheet files?

tests were initially failing as `isW3C()` is only available in the main branch of instaclick/php-webdriver https://github.com/instaclick/php-webdriver/blob/master/lib/WebDriver/Session.php#L136

@stof ah interesting :smile_cat: :+1: Would you please consider accepting this change into this project in the meantime? It's a small update, not disruptive to existing users, is successfully running...

@stof thanks for the review! I'll address the issues you've raised

@stof ready for review! I'll wait on making a release of lullabot/php-webdriver until this PR is happy

Hi @stof - could you please let me know if the project is willing to accept this PR so I can make a release of php-webdriver? We can move Drupal...

We can use the normal fetch API instead of either Axios or SuperAgent, with a polyfill for node https://www.npmjs.com/package/isomorphic-fetch