face-api.js icon indicating copy to clipboard operation
face-api.js copied to clipboard

Published 20 hours ago • verified publisher icon justadudewhohacks

Fixing issue #222: FaceLandmarks68 left and right eyes/brows are reversed.

Open a-bronx opened this issue 5 years ago • 3 comments

NOTE: this is a "blind" fix, as I failed to build the library and run unit tests on my Windows box without Python (and I have no interest to install it). Up to you to verify and correct it.

a-bronx avatar Mar 01 '19 22:03 a-bronx

Sorry for the late reply on this one. I think it's better not to change the API, in order to not break anything for users of this package. Technically the terms left and right here are not wrong, they are just from an observers persepective.

justadudewhohacks avatar Mar 27 '19 14:03 justadudewhohacks

This API should be documented then to avoid surprises.

a-bronx avatar Mar 27 '19 15:03 a-bronx

Since we use typedoc, adding a comment in the function description would be helpful probably.

justadudewhohacks avatar Apr 08 '19 19:04 justadudewhohacks