Eugene Dorfman

Results 48 comments of Eugene Dorfman

Hi @hhhjort thanks for the comment. I've submitted a proposal: #4084 and a PoC PR: #4085 to illustrate the point. I think the lightweight DI mechanism would do for logger...

@bsardo mentioned that a similar thing is done with the time package - will take a look

Hi guys, @And1sS @CTMBNara, just checking: any ETA to get a review? Thanks.

Hi @And1sS, thanks for the first pass. @softcoder594 has addressed the review comments. Could you please take another look?

Hi guys! 2 new features were added per [Bret's suggestion](https://github.com/prebid/prebid.github.io/pull/5931#pullrequestreview-2737442084): - Optable Targeting API endpoint is now added to the host-level config with tenant and origin parameters at the account-level...

Hi guys, just checking in. There are clients awaiting to use this module, so we'd appreciate the next round of review comments so we could conclude quicker, or please let...

I think we need to carefully consider option 2, but not from the mobile native webviews perspective. Mobile native webviews can do synchronous writes and it would not impact the...

Hi @bretg, thank you for the review! We'll work on addressing these design issues.

PMC: it makes sense to add an `PrebidMAXPostbidAdapter` as a separate adapter class and enable bidfloor logic on it. This will allow tying it to AppLovin placements' CPMs and at...

Hi @linux019 tried to reproduce - I don't get these warnings in the console when module is disabled, but still mentioned in the `hook_execution_plan`. I am running the `go run...