just-the-docs icon indicating copy to clipboard operation
just-the-docs copied to clipboard

Add `tabindex=0` to all code blocks

Open mattxwang opened this issue 1 year ago • 0 comments

This fixes an accessibility issue flagged by #1513; unlike #1531, which only affects our docs, this change actually affects all of our users (so this warrants a bit of testing).

This is a bit hacky. Ideally, I'd like to do this at the markdown level, since this doesn't serve folks who have JS disabled (among many other things). But, we can't execute arbitrary ruby code for users on the pages gem.

Some things to investigate before merging:

  • is there any way for me to deal with this using some rouge option? (seems like nothing in kramdown)
  • how does this affect alternate syntax highlighters
  • does using something like asciidoc break this?
  • is this always the right thing to do accessibility-wise (and/or should I use a different selector)

mattxwang avatar Sep 06 '24 19:09 mattxwang