angular-builders
angular-builders copied to clipboard
Use schematics for installation steps
From @meltedspark on August 13, 2018 14:40
The following should be done automatically with schematics instead of requiring the user to do it manually:
- Removing Karma related stuff
- Updating Typescript configs
- Updating angular.json
Copied from original issue: angular-builders/jest#3
I've developed some schematics doing this. I was about to develop my own builder for this when I find your project. We maybe can do something together...?
Sure, you're more than welcome to make a PR for this!
You'll have to modify your schematics a bit (as it should change angular.json instead package.json).
It's also unnecessary to create Jest setup files (they are already included in the builder) and install Jest (as it is just a builder).
Basically the schematics for this builder would have to do the installations steps (except for step 1) described in the README.
If you're up to implementing this, please go ahead!
I would also say that such a PR should contain an end-to-end test of installing the library, configuring the project using schematics and running the tests, but if it is too much I can handle this part.
@davinkevin Shall I take it from here or you'd like to implement that?
You can take it... I don't have time to do this sadly. 😓 Sorry
I've actually made a schematic which includes your jest-builder. It can be found here: https://github.com/froko/ng-essentials
Any feedback is highly welcome!
@froko Great work! I think it is a great initiative!
Do you think it's possible for you to create a PR with the same functionality here? To make it all-in-one solution, so that one could simply run ng add @angular-builders/jest
?
If not, would you mind me borrowing your source code and adding it here myself (with copyright of course)?
Thank you for your great work. @froko @just-jeb When will this feature be available? It took me ten minutes to finish it manually today. If you can provide a schematics, my work efficiency will increase 300 times. 😁
Hi everyone, I've updated the @briebug/jest-schematic
to utilize this builder and support single and multi app/lib workspaces. It's published under a pre-release right now and can be installed at:
ng add @briebug/[email protected]
Feedback is welcome.
@schuchard what do you think about adding this schematics as part of the builder? So that you could just run ng add @angular-builders/jest
?