hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

feat(connector): add dummy connector template code

Open ThisIsMani opened this issue 1 year ago • 1 comments

Type of Change

  • [ ] Bugfix
  • [x] New feature
  • [ ] Enhancement
  • [ ] Refactoring
  • [ ] Dependency updates
  • [ ] Documentation
  • [ ] CI/CD

Description

Add template code for dummy connector and feature flags to enable and disable it.

Additional Changes

  • [ ] This PR modifies the API contract
  • [ ] This PR modifies the database schema
  • [ ] This PR modifies application configuration/environment variables

Motivation and Context

#726

How did you test it?

Checklist

  • [x] I formatted the code cargo +nightly fmt --all
  • [x] I addressed lints thrown by cargo clippy
  • [ ] I reviewed submitted code
  • [ ] I added unit tests for my changes where possible
  • [ ] I added a CHANGELOG entry if applicable

ThisIsMani avatar Apr 25 '23 06:04 ThisIsMani

When you're opening PRs that fix an open issue, please link the issue to your PR by using one of the keywords recognized by GitHub. It makes tracking issues and PRs easier for us. For this PR, I've done it for you, please try to follow it for further PRs you open.

SanchithHegde avatar Apr 25 '23 07:04 SanchithHegde

Hi @ThisIsMani , Is dummyconnector planned to behind a compile time feature flag? I thought the plan was to also use it as dummy connector for any customer who signs up, to experience the dashboard.

ashokkjag avatar May 04 '23 07:05 ashokkjag

Hi @ThisIsMani , Is dummyconnector planned to behind a compile time feature flag? I thought the plan was to also use it as dummy connector for any customer who signs up, to experience the dashboard.

@ashokkjag, yes the usecase for the dummyconnector is the same as you said. I wanted to make it as an option to have the dummyconnector to be disabled using a feature flag.

ThisIsMani avatar May 04 '23 07:05 ThisIsMani