hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

[FEATURE] : [WELLSFARGO] Add Integrity Check Support for Authorize, PSync, Refund and RSync Flows

Open bsayak03 opened this issue 3 months ago • 5 comments

Feature Description/Summary

Integrity check is a scenario where there is a discrepancy between the amount sent in the request and the amount received from the connector, which is checked during response handling.

Context

Integrity checks in a payments flow are critical for ensuring data consistency, correctness, and security when dealing with amounts between Hyperswitch and connectors like Adyen, Stripe, Razorpay, etc.

Starter Tasks

  • In the handle_response function of Authorize/PSync/Refund/RSync, you will have to call the respective functions - get_authorise_integrity_object for Authorize, get_sync_integrity_object for Payments Sync, get_refund_integrity_object for Refund and RSync and get_capture_integrity_object for Capture.
  • You would have to call these functions from crates/hyperswitch_connectors/src/utils.rs.
  • These functions expect amount_convertor, amount and currency.
  • You can take a look at this PR for reference.

Implementation Hints

  • You can go to crates/hyperswitch_connectors/src/connectors/wellsfargo.rs and call the respective integrity check function as stated above in the handle_response function

Acceptance Criteria

  • [ ] Request and Response body added for each of the flows where integrity check is applied.
  • [ ] All the required GitHub checks passing
  • [ ] Formatted the code using cargo +nightly fmt --all

How to Test it

  • Hardcode the amount or currency field that is being passed to the connector different from the one you are passing in the request body
  • This way you would be able to reproduce the integrity checks error message while testing.

Mentor Contact

  • Tag @bsayak03 [Sayak Bhattacharya] in the comments if you have any doubts/queries

Resources

Here are a few sample PRs :

  • https://github.com/juspay/hyperswitch/pull/8075
  • https://github.com/juspay/hyperswitch/pull/8049

Pre-Flight

Have you spent some time checking if this feature request has been raised before?

  • [x] I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Submission Process:

  • Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
  • Once assigned, submit a pull request (PR).
  • Maintainers will review and provide feedback, if any.
  • Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

bsayak03 avatar Sep 01 '25 20:09 bsayak03

Hey, I can take a shot at this!

AlexanderWangY avatar Sep 02 '25 05:09 AlexanderWangY

Hey, Can I work on this?

viboognesh avatar Sep 02 '25 06:09 viboognesh

Might as well.

Meshou23 avatar Sep 02 '25 09:09 Meshou23

Hi @bsayak03 Can i work in this?

MRADULTRIPATHI avatar Sep 02 '25 22:09 MRADULTRIPATHI

Hello @bsayak03 , I'm eager to work on this issue. Kindly assign it to me!!

Jatan196 avatar Sep 03 '25 14:09 Jatan196

Hey, I can take a shot at this!

@AlexanderWangY assigning the issue to you.

neerajkumar-n avatar Sep 26 '25 07:09 neerajkumar-n

@AlexanderWangY - Wondering if you are working the issue.

neerajkumar-n avatar Oct 01 '25 08:10 neerajkumar-n

@neerajkumar-n can you assign me this?, if inactive.

aryan-212 avatar Oct 01 '25 09:10 aryan-212

@neerajkumar-n Hey I should have a PR coming by tomorrow evening!

AlexanderWangY avatar Oct 03 '25 00:10 AlexanderWangY

@neerajkumar-n can you assign me this?, if inactive.

This issue is already assigned to @AlexanderWangY . You can maybe check the other issues listed under this repo @aryan-212

bsayak03 avatar Oct 03 '25 18:10 bsayak03

Hi @bsayak03 . Apologies for the delay, I've just submitted a preliminary PR for this issue. Feel free to review it or have someone else whenever!

AlexanderWangY avatar Oct 03 '25 22:10 AlexanderWangY

Hi @bsayak03 . Apologies for the delay, I've just submitted a preliminary PR for this issue. Feel free to review it or have someone else whenever!

@AlexanderWangY on it

bsayak03 avatar Oct 04 '25 10:10 bsayak03